Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-resize does not match video aspect ratio (Windows) #565

Closed
feross opened this issue May 23, 2016 · 1 comment
Closed

Auto-resize does not match video aspect ratio (Windows) #565

feross opened this issue May 23, 2016 · 1 comment
Labels
bug good first contribution help wanted
Milestone
1.0

Comments

@feross
Copy link
Member

feross commented May 23, 2016

What version of WebTorrent Desktop? (See the 'About WebTorrent' menu)

0.5.1

What operating system and version?

Windows 10

What did you do?

Start the Sintel torrent. The window automatically resizes the match the video size.

What did you expect to happen?

The aspect ratio should match the video.

What actually happened?

The aspect ratio was slightly off, as if the header size is not being taken into account.

Observe the black bars on the sides:

screen shot 2016-05-22 at 22 10 40
@feross feross added the bug label May 23, 2016
@feross feross added this to the v1.0 milestone Jun 1, 2016
@Goldob Goldob mentioned this issue Jun 17, 2016
Closed
feross added a commit that referenced this issue Aug 11, 2016
@feross
Resize the window's content area
3232e96 
Fixes: #565

This was trivial thanks to a new Electron API in 1.3.3
@feross feross mentioned this issue Aug 11, 2016
Merged
@feross
Copy link
Member Author

feross commented Aug 20, 2016

Released in WebTorrent Desktop v0.11!

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug good first contribution help wanted
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@feross