Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use poster.jpg file as the poster image, if present #501

Closed
feross opened this issue May 13, 2016 · 0 comments
Closed

Use poster.jpg file as the poster image, if present #501

feross opened this issue May 13, 2016 · 0 comments
Labels
area/ux enhancement
Milestone
1.0

Comments

@feross
Copy link
Member

feross commented May 13, 2016

When selecting a poster image, we currently use the largest image file in the torrent, or take a frame from the largest video file.

However, if there's a file named poster.jpg, let's always use it. We'll interpret it as a hint from the .torrent file creator that they've specially produced a nice image to use.
@feross feross changed the title Use poster.jpg file as the poster image when it's available. Use poster.jpg file as the poster image, if present May 13, 2016
@feross feross modified the milestone: v1.0 May 21, 2016
@bnjmnt4n bnjmnt4n mentioned this issue May 21, 2016
Merged
dcposch pushed a commit that referenced this issue May 22, 2016
@bnjmnt4n @dcposch
Use poster.jpg file as the poster image if available. (#558)
b22c228 
Closes #501.
mathiasvr pushed a commit to mathiasvr/webtorrent-desktop that referenced this issue May 26, 2016
@bnjmnt4n @dcposch
Use poster.jpg file as the poster image if available. (webtorrent#558)
f7b4633 
Closes webtorrent#501.
@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/ux enhancement
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@feross