Allow blank gh and li #3787
Merged
Allow blank gh and li #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
approved these changes
Mar 17, 2025
itsisak
requested changes
Mar 17, 2025
norbye
force-pushed
the
allow-empty-gh-li
branch
from
4407681 to
dc63ab5
Compare
norbye
force-pushed
the
allow-empty-gh-li
branch
from
dc63ab5 to
6cc0197
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3787 +/- ##
=======================================
Coverage 89.94% 89.95%
=======================================
Files 738 739 +1
Lines 23898 23904 +6
=======================================
+ Hits 21496 21502 +6
Misses 2402 2402 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow passing empty github and linkedin usernames (neat to enable removing it after you added it if you so desire)
Testing
Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.
Resolves ... (either GitHub issue or Linear task)