Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punycode -> punycode.js. Update deps. Bump to 3.5.1. #161

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

Hexagon
Copy link
Member

@Hexagon Hexagon commented Mar 6, 2024

Alternative to #160, fixing #159 by replacing dependency punycode with punycode.js to avoid collision with the deprecated non-userland node component also named punycode.

Updated some other dependencies in the process too.

@Hexagon Hexagon requested a review from JamesCullum March 6, 2024 19:04
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.86%. Comparing base (a7d1bdf) to head (1c66960).
Report is 1 commits behind head on master.

❗ Current head 1c66960 differs from pull request most recent head 46f1224. Consider uploading reports for the commit 46f1224 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   92.86%   92.86%           
=======================================
  Files          16       16           
  Lines        6027     6027           
=======================================
  Hits         5597     5597           
  Misses        430      430           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamesCullum
Copy link
Member

Thanks a lot!

@JamesCullum JamesCullum merged commit 87fec22 into webauthn-open-source:master Mar 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants