fix(core): proxy-loader behavior is not correct when query is string #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsdoctor ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SoonIter
force-pushed
the
fix/proxy-loader-query
branch
2 times, most recently
from
3987c1b to
c35a2df
Compare
SoonIter
force-pushed
the
fix/proxy-loader-query
branch
from
c35a2df to
aaac6ce
Compare
SoonIter
force-pushed
the
fix/proxy-loader-query
branch
from
aaac6ce to
720742c
Compare
SoonIter
commented
Jan 29, 2024
SoonIter
force-pushed
the
fix/proxy-loader-query
branch
2 times, most recently
from
bb73e9a to
ce5ff7d
Compare
easy1090
reviewed
Jan 29, 2024
|
SoonIter
force-pushed
the
fix/proxy-loader-query
branch
from
988072e to
e47357e
Compare
easy1090
approved these changes
Jan 29, 2024
|
thanks :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are some problems in the implementation of two places.
in loader
this.queryhitsthis.resourceQuerywhen
rule.useis a function, rsdoctor cannot handle correctlyRelated Links
closes #155
Checklist
pnpm run change.