Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match config.Protocol for global flag assignment #234

Open
terrorbyte opened this issue Sep 11, 2024 · 0 comments · May be fixed by #267
Open

Match config.Protocol for global flag assignment #234

terrorbyte opened this issue Sep 11, 2024 · 0 comments · May be fixed by #267
Assignees
Labels
enhancement New feature or request

Comments

@terrorbyte
Copy link
Collaborator

terrorbyte commented Sep 11, 2024

Currently we make assumptions about web servers being attacked and have some global flags that apply and make those assumptions. This isn't always the case nor wanted behavior. Instead, we should put a check on the config.Protocol that will apply a set of flags/behaviors based on the target. That way, we can provide protocol specific flags and settings, as well as suppress framework messages that are irrelevant to the exploit (my IPv6 windows fragmentation PoC shouldn't be printing the HTTP user agent).

In addition, this should also let us do things like adding HTTP protocol specific flags for missing vhost or path/rootpath flags.


See #180 (comment)

@terrorbyte terrorbyte added the enhancement New feature or request label Sep 11, 2024
@terrorbyte terrorbyte self-assigned this Sep 11, 2024
terrorbyte added a commit that referenced this issue Nov 8, 2024
Closes #234

Allows for protocols to have explicit flags that will resolve when they
get defined. For example, if your exploit defines "HTTP" as it's
protocol, this change automatically applies the "user-agent" flag to the
cli args and if it does not it will not appear.

I of course wanted to support multi-protocol or sub-protocol situations,
so this also adds the `cli.AddProtocolFlags` function that will allow
for manually adding flags where applicable.

Also adds a few checks for whether to print the Global User-Agent string
based on that and a quick Warning check for if proxies are supported.
@terrorbyte terrorbyte linked a pull request Nov 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant