Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checkbox attributes #1452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

hiagolcm
Copy link
Contributor

What is the purpose of this pull request?

We need to collect click data from the Checkbox in the Facets component. In order to this, We must have the ability to add data-attributes to the Checkbox component

Example:

<Checkbox
        id={checkBoxId}
        checked={selected}
       ...
        data-full-text={searchQuery?.variables?.fullText}
        data-initial-query={initialquery}
        data-initial-map={initialmap}
        data-is-clicked={selected.toString()}
        data-facet-key={facet.key}
        data-facet-value={facet.value}
      />

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

How to test this change?

Workspace

image

Copy link

vercel bot commented Mar 11, 2025

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this project.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant