function/function inserted into the element button for use in accessibility #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility applications and automated testing
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hello @gabriel291-silva , could you describe better how your modification works as well as prints demonstrating its effect? |
gabriel291-silva
changed the title
|
### Description: Function inserted into the button element for accessibility purposes. For this improvement in the code, I simply added a role and an aria-label so that it could be validated with accessibility software. I will add a screenshot of the before and after, along with a link to the product page. The button being tested is the arrow for the reviews at the bottom of the page.antes :
before after workspace de test: https://fixstyleguide--hmartus.myvtex.com/ginger-tea-with-honey-2-2lb-1kg-/p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…bility applications and automated testing
What is the purpose of this pull request?
I inserted a definition in the component, this modification is for accessibility app
What problem is this solving?
acessibility problems