Adds registry-url and always-auth parameters #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
add-registry-url
branch
2 times, most recently
from
97c37fe to
1c7f862
Compare
rwjblue
reviewed
Aug 30, 2021
There was a problem hiding this comment.
Thanks for working on this!
Would you mind adding an "acceptance" test confirming that things work "end to end"?
I'm thinking something
action/.github/workflows/CI.yml
Lines 32 to 57 in 76620aa
Which might look like:
test-specified-registry-url:
runs-on: "${{ matrix.os }}-latest"
strategy:
fail-fast: false
matrix:
os: [ubuntu, macOS, windows]
steps:
- uses: actions/checkout@v1
- run: npm ci
- run: npm run build
- uses: ./
with:
registry-url: "https://some.path.here.com/lol/"
- run: tests/log-info.sh
- run: tests/check-version.sh 'volta' ${{ matrix.volta-version }}
- run: volta install [email protected] [email protected]
- run: tests/check-version.sh 'node' 'v10.17.0'
- run: tests/check-version.sh 'yarn' '1.19.0'
- run: tests/check-registry.sh 'npm' 'https://some.path.here.com/lol/'tests/check-registry.sh can basically echo the file contents and then confirm via npm config get registry
rwjblue
reviewed
Aug 30, 2021
rwjblue
reviewed
Aug 30, 2021
pzuraq
force-pushed
the
add-registry-url
branch
from
1c7f862 to
8e65095
Compare
rwjblue
reviewed
Aug 30, 2021
pzuraq
force-pushed
the
add-registry-url
branch
from
8e65095 to
758a6f5
Compare
These parameters match the ones passed to the setup-node GH action. The implementation is mostly taken from there, with a few updates/modifications (e.g. using `fs/promises`).
pzuraq
force-pushed
the
add-registry-url
branch
from
758a6f5 to
f22e265
Compare
rwjblue
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These parameters match the ones passed to the setup-node GH action. The
implementation is mostly taken from there, with a few
updates/modifications (e.g. using
fs/promises).Fixes #47