Add package-json-path input to specify location of package.json
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
support-pinning-in-subdirs
branch
from
18ad453 to
57c390c
Compare
scalvert
approved these changes
Sep 7, 2022
rwjblue
force-pushed
the
support-pinning-in-subdirs
branch
3 times, most recently
from
e4d95fe to
dbd08ea
Compare
For projects without a `package.json` in the working directory root we currently do not support the ability to pin specific `node-version` | `yarn-version` | `npm-version` (we are only able to ensure that the given versions are preinstalled, but when `node`|`yarn`|`npm` are ultimately ran they might not use the specified). This is because we are only able to pin if we can find the `package.json` which contains the `volta` property (which we need to override). This adds a new input `package-json-path` that can be used to specify _where_ in a project the `package.json` is actually located. When not specified, we will use `package.json` (e.g. a `package.json` in the root of the working directory).
rwjblue
force-pushed
the
support-pinning-in-subdirs
branch
from
dbd08ea to
2f8c383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For projects without a
package.jsonin the working directory root we currently do not support the ability to pin specificnode-version|yarn-version|npm-version(we are only able to ensure that the given versions are preinstalled, but whennode|yarn|npmare ultimately ran they might not use the specified). This is because we are only able to pin if we can find thepackage.jsonwhich contains thevoltaproperty (which we need to override).This adds a new input
package-json-paththat can be used to specify where in a project thepackage.jsonis actually located. When not specified, we will usepackage.json(e.g. apackage.jsonin the root of the working directory).Closes #85