fix: missing results in ListObjects/CommonPrefixes #87
+28
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ashish-amarnath,
carlisia,
dsu-igeek,
nrb and
zubron
Paginate the results using NextMarker/Marker so that all results are returned instead of potentially only a subset of objects. When listing blobs, each page may have up to the max results (default 5000). However: you may still get less than that amount. To get all results, azure requires us to paginate through them using NextMarker/Marker until NextMarker is unset in the response. Currently only the first page is ever considered, since this is called only once. This fix affects the Backup Sync Controller which uses these to list the available backups and delete orphaned backups if they are not found in storage. When providing an incomplete list of results, the controller erroneously removes backup resources from the cluster when they still exist in storage. Signed-off-by: Justen Walker <[email protected]>
zubron
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When listing blobs, each page may have up to the max results (default 5000). However: you may still get less than that amount. To get all results, azure requires us to paginate through them using NextMarker/Marker until NextMarker is unset in the response. Currently only the first page is ever considered, since this is called only once.
This fix affects the Backup Sync Controller which uses these to list the available backups and delete orphaned backups if they are not found in storage. When providing an incomplete list of results, the controller erroneously removes backup resources from the cluster when they still exist in storage.
Signed-off-by: Justen Walker [email protected]