-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for incremental snapshots of Azure disks #52
add support for incremental snapshots of Azure disks #52
Conversation
e0ebaab
to
ce50ac0
Compare
signed off the commit |
@stephanwehr Thank you for your PR. |
closing and reopening to re-trigger DCO |
That didn't seem to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting on the testing info and DCO.
Signed-off-by: Stephan Wehr <[email protected]>
ce50ac0
to
3d038eb
Compare
Completed DCO The tests mentioned in the 1st comment were done manually against an AKS cluster. Test 1
Create a backup manually or via schedule. Test 2
Create a backup manually or via schedule. Test 3
Create a backup, the backup should fail with status "PartiallyFailed (N error(s))"
To get the error message run:
Make sure no snapshot is taken if the backup fails by listing Azure resources. Check if Velero can delete the failed backup by running: CAUTION: Backups created by schedules will fail if the parameter incremental is set to a non boolean value and need to be cleaned up by deleting the failed backups. |
@stephanwehr All the 3 test cases behaved as mentioned by you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephanwehr Thanks for putting up this PR and @Juhibhadviya19 thanks for the confirmation on the testing.
LGTM! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@stephanwehr and @Juhibhadviya19 thanks for the testing! When restoring from an incremental snapshot, is there any difference in usage, or does Azure do the association under the covers? |
There is no difference in the usage. The Azure sdk takes care of this for us. From Velero's perspective, it is the usual
Is this a scenario that you were able to verify @Juhibhadviya19 ? |
EDIT: False alarm. My bad. removing hold. I was also able to run backup with |
@nrb this is ready for merge, unless you have other questions or comments |
Thanks for testing that all @ashish-amarnath! |
thanks. tentative time for releasing Incremental backup support for AKS PVC, with the Release Label Please. |
@Sathishkunisai We should have a release with this change end of august, at the same time as Velero 1.5. |
Signed-off-by: Mateus Oliveira <[email protected]>
Closes #25
Passed the following test cases:
Test: Omit parameter "incremental"
Result: Full snapshot taken
Test: Set parameter "incremental" to "true"
Result: Incremental snapshot taken
Test: Set parameter "incremental" to "test value"
Result: Backup fails partially, no snapshot taken, error message in log