-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support setting Storage Account Key via configuration #32
Conversation
Signed-off-by: Martin Odstrcilik <[email protected]>
e9448ae
to
64164da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the updates @jaygridley, LGTM! @carlisia @nrb @ashish-amarnath PTAL.
@jaygridley Is this ready to be merged? |
Yes, another required approval pending. |
@carlisia @nrb @ashish-amarnath - gentle reminder to please review this PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I had missed this.
LGTM, just a request for a tiny doc change if you would please!
Signed-off-by: Martin Odstrcilik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thank you!
thanks again @jaygridley!! |
Bug 2189173 - upgrade golang.org/x/net to 0.7.0
This PR resolves #10