Added the capability to add custom endpoints for storage and azure active directory endpoint

[Jeremy-Boyle]

Why:
This feature pull request allows the user to define the storage endpoints and azure active directory endpoints. This is needed for azure gov / other regions where the directory and storage endpoints aren't public and do not fall under the default provided clouds.

Additions:

• Go Int Tests to verify that the output is as expected
• Added new backupstoragelocation config values
  • activeDirectoryAuthorityURI
• Added new volumesnapshotlocation config values
  • activeDirectoryAuthorityURI

[shubham-pampattiwar]

@Jeremy-Boyle changes look same to me, maybe move the error handling to the init() function. Also, Do we need any other env vars that might be needed for such usecases ?
@ywk253100 thoughts ?

[Jeremy-Boyle]

I can take a look and see if there is any other use cases that might need to be added. As far as I’m aware this would allow for the custom endpoints that velero needs.

I can look into updating the error handling to a more appropriate place.

[Jeremy-Boyle]

@shubham-pampattiwar

I see the call here in init,

velero-plugin-for-microsoft-azure/velero-plugin-for-microsoft-azure/object_store.go

Lines 354 to 357 in 0fa9ea0

	cloudConfig, err := cloudFromName(os.Getenv(cloudNameEnvVar))
	if err != nil {
	return errors.Wrap(err, "unable to parse azure cloud name environment variable")
	}

However, since its contingent on the flag AZURE_CLOUD_NAME being set to AzureCustomCloud, the current solution may best otherwise additional logic would need to be setup in init to verify that AZURE_CLOUD_NAME = AzureCustomCloud and then check the environment variables before calling the cloudFromName function.

Any suggestions?

[codecov-commenter]

Codecov Report

Merging #195 (6e3d49b) into main (98ec8ec) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   13.60%   13.46%   -0.14%     
==========================================
  Files           4        4              
  Lines         691      698       +7     
==========================================
  Hits           94       94              
- Misses        594      601       +7     
  Partials        3        3              

Files Changed	Coverage Δ
velero-plugin-for-microsoft-azure/object_store.go	2.18% <0.00%> (-0.03%)	⬇️
...o-plugin-for-microsoft-azure/volume_snapshotter.go	23.45% <0.00%> (-0.24%)	⬇️

[ywk253100]

@Jeremy-Boyle @shubham-pampattiwar
We introduced a new configuration item storageAccountURI for users to customize the storage account endpoint in PR #185, seems the changes in this PR contain overlap with that.
So how about that we introduce a new item activeDirectoryAuthorityHost to overwrite the default value if provided?

cc @anshulahuja98

[Jeremy-Boyle]

storageAccountURI

This is a much better route, I will update this PR to fall in line.

[Jeremy-Boyle]

@ywk253100 Updated based on your recommendations.

[Jeremy-Boyle]

@ywk253100 @shubham-pampattiwar @aramprice

Any movement ?

Would like to get this updated ASAP

[ywk253100]

@Jeremy-Boyle Will review it later

[Jeremy-Boyle]

Please take a look at let me know @ywk253100

[Jeremy-Boyle]

Fixed Pull, there was some weird commits that were changing too much from the readme file and some merge conflicts, squashed into one commit.

Looks good now

[Jeremy-Boyle]

@ywk253100 @shubham-pampattiwar @aramprice

Does this PR look good now ? Would like to pull these changes in, thanks!