-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the capability to add custom endpoints for storage and azure active directory endpoint #195
Added the capability to add custom endpoints for storage and azure active directory endpoint #195
Conversation
@Jeremy-Boyle changes look same to me, maybe move the error handling to the init() function. Also, Do we need any other env vars that might be needed for such usecases ? |
I can take a look and see if there is any other use cases that might need to be added. As far as I’m aware this would allow for the custom endpoints that velero needs. I can look into updating the error handling to a more appropriate place. |
I see the call here in init, velero-plugin-for-microsoft-azure/velero-plugin-for-microsoft-azure/object_store.go Lines 354 to 357 in 0fa9ea0
However, since its contingent on the flag Any suggestions? |
Codecov Report
@@ Coverage Diff @@
## main #195 +/- ##
==========================================
- Coverage 13.60% 13.46% -0.14%
==========================================
Files 4 4
Lines 691 698 +7
==========================================
Hits 94 94
- Misses 594 601 +7
Partials 3 3
|
@Jeremy-Boyle @shubham-pampattiwar |
This is a much better route, I will update this PR to fall in line. |
@ywk253100 Updated based on your recommendations. |
@ywk253100 @shubham-pampattiwar @aramprice Any movement ? Would like to get this updated ASAP |
@Jeremy-Boyle Will review it later |
Please take a look at let me know @ywk253100 |
d729eec
to
2b9ddf5
Compare
Fixed Pull, there was some weird commits that were changing too much from the readme file and some merge conflicts, squashed into one commit. Looks good now |
Signed-off-by: Jeremy-Boyle <[email protected]>
2b9ddf5
to
2faf911
Compare
@ywk253100 @shubham-pampattiwar @aramprice Does this PR look good now ? Would like to pull these changes in, thanks! |
Why:
This feature pull request allows the user to define the storage endpoints and azure active directory endpoints. This is needed for azure gov / other regions where the directory and storage endpoints aren't public and do not fall under the default provided clouds.
Additions: