Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The velero-plugin-formicrosoft-azure docs have started advising #186

Conversation

gwynforthewyn
Copy link

adding environment variables in the credentials file. This can work, but the environment variables must be loaded early so that functions requiring those variables work correctly.


For testing this patch, I build the plugin container and deployed it to a govcloud AKS cluster. Details on why this has to be tested in govcloud in the bug report at vmware-tanzu/velero#6196, specifically in the comment vmware-tanzu/velero#6196 (comment)

@gwynforthewyn
Copy link
Author

DCO is claiming this commit isn't signed off, but I have the sign off line in the commit message. Any advice would be appreciated.

@ywk253100
Copy link
Contributor

@gwynforthewyn Thanks for the PR!
The Details link of DCO checking explains the reason why it failed:

Commit sha: [7bacc5f](https://github.com/vmware-tanzu/velero-plugin-for-microsoft-azure/pull/186/commits/7bacc5fcaaf0f07b2337c4048b8993cb3e8b6787), Author: Gwyn, Committer: Gwyn; Expected "Gwyn [[email protected]](mailto:[email protected])", but got "Gwendolyn James [[email protected]](mailto:[email protected])".

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Merging #186 (c84f8c3) into main (5b19243) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   14.07%   13.96%   -0.11%     
==========================================
  Files           4        4              
  Lines         668      673       +5     
==========================================
  Hits           94       94              
- Misses        571      576       +5     
  Partials        3        3              
Impacted Files Coverage Δ
velero-plugin-for-microsoft-azure/object_store.go 2.34% <0.00%> (-0.05%) ⬇️

adding environment variables in the credentials file. This can work,
but the environment variables must be loaded early so that
functions requiring those variables work correctly.

Signed-off-by: Gwyn <[email protected]>
@gwynforthewyn gwynforthewyn force-pushed the 6196-populate-env-vars-early branch from 7bacc5f to c84f8c3 Compare April 28, 2023 15:03
@gwynforthewyn
Copy link
Author

@ywk253100 Thank you!! I totally missed that! DCO is passing now 🙂

@ywk253100
Copy link
Contributor

@shubham-pampattiwar Please take a look at this PR

@shubham-pampattiwar shubham-pampattiwar merged commit b5bc8ba into vmware-tanzu:main May 10, 2023
0x113 added a commit to catalogicsoftware/velero-plugin-for-microsoft-azure that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants