The velero-plugin-formicrosoft-azure docs have started advising #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO is claiming this commit isn't signed off, but I have the sign off line in the commit message. Any advice would be appreciated. |
|
@gwynforthewyn Thanks for the PR! |
Codecov Report
@@ Coverage Diff @@
## main #186 +/- ##
==========================================
- Coverage 14.07% 13.96% -0.11%
==========================================
Files 4 4
Lines 668 673 +5
==========================================
Hits 94 94
- Misses 571 576 +5
Partials 3 3
|
adding environment variables in the credentials file. This can work, but the environment variables must be loaded early so that functions requiring those variables work correctly. Signed-off-by: Gwyn <[email protected]>
gwynforthewyn
force-pushed
the
6196-populate-env-vars-early
branch
from
7bacc5f to
c84f8c3
Compare
|
@ywk253100 Thank you!! I totally missed that! DCO is passing now 🙂 |
ywk253100
approved these changes
May 8, 2023
|
@shubham-pampattiwar Please take a look at this PR |
shubham-pampattiwar
approved these changes
May 10, 2023
0x113
added a commit
to catalogicsoftware/velero-plugin-for-microsoft-azure
that referenced
this pull request
Dec 21, 2023
Changes from: vmware-tanzu#186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding environment variables in the credentials file. This can work, but the environment variables must be loaded early so that functions requiring those variables work correctly.
For testing this patch, I build the plugin container and deployed it to a govcloud AKS cluster. Details on why this has to be tested in govcloud in the bug report at vmware-tanzu/velero#6196, specifically in the comment vmware-tanzu/velero#6196 (comment)