Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the cp from busybox - 1.5.x #179

Merged

Conversation

reasonerjt
Copy link
Contributor

Use a simple program to copy the plugin binary, so that we will not depend on busybox.

This commit also bumps up golang to 1.19 and some depdendencies for plugin v1.5.x

@github-actions github-actions bot requested review from qiuming-best and sseago April 14, 2023 07:40
@reasonerjt reasonerjt requested review from ywk253100 and removed request for qiuming-best April 14, 2023 07:41
ywk253100
ywk253100 previously approved these changes Apr 14, 2023
Dockerfile Outdated
USER 65532:65532
ENTRYPOINT ["cp", "/plugins/velero-plugin-for-microsoft-azure", "/target/."]
ENTRYPOINT ["cp", "/plugins/velero-plugin-for-microsoft-azure", "/target/velero-plugin-for-microsoft-azure"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cp should be renamed to cp-plugin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shoot, thanks!

Use a simple program to copy the plugin binary, so that we will not depend on
busybox.

This commit also bumps up golang to 1.19 and some depdendencies for
plugin v1.5.x

Signed-off-by: Daniel Jiang <[email protected]>
@ywk253100 ywk253100 merged commit c5422d4 into vmware-tanzu:release-1.5 Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants