Replace the cp from busybox - 1.5.x #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reasonerjt
requested review from
ywk253100
and removed request for
qiuming-best
ywk253100
previously approved these changes
Apr 14, 2023
blackpiglet
reviewed
Apr 14, 2023
Dockerfile
Outdated
| USER 65532:65532 | ||
| ENTRYPOINT ["cp", "/plugins/velero-plugin-for-microsoft-azure", "/target/."] | ||
| ENTRYPOINT ["cp", "/plugins/velero-plugin-for-microsoft-azure", "/target/velero-plugin-for-microsoft-azure"] |
There was a problem hiding this comment.
cp should be renamed to cp-plugin.
Use a simple program to copy the plugin binary, so that we will not depend on busybox. This commit also bumps up golang to 1.19 and some depdendencies for plugin v1.5.x Signed-off-by: Daniel Jiang <[email protected]>
reasonerjt
force-pushed
the
replace-busybox-cp-1.5
branch
from
c6530ba to
dc8289a
Compare
blackpiglet
approved these changes
Apr 14, 2023
ywk253100
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a simple program to copy the plugin binary, so that we will not depend on busybox.
This commit also bumps up golang to 1.19 and some depdendencies for plugin v1.5.x