Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the changes made to doc in #111 #173

Merged
merged 1 commit into from
Mar 19, 2023

Conversation

ywk253100
Copy link
Contributor

We introduced changes in #111 to remove the logic of listing storage account access key, the Velero Azure plugin supports auth via Azure AD directly after the changes, but that isn't enough as Restic/Kopia still doesn't support auth via Azure AD at this moment, this will cause filesystem backup failure on Azure.

So we revert the doc change in this commit and Velero still needs the permission of listing storage access key to work as expected. But as we keep the code changes, users can workaround the permission issue by refer to vmware-tanzu/velero#5984

We introduced changes in vmware-tanzu#111 to remove the logic of listing storage account access key, the Velero Azure plugin supports auth via Azure AD directly after the changes, but that isn't enough as Restic/Kopia still doesn't support auth via Azure AD at this moment, this will cause filesystem backup failure on Azure.

So we revert the doc change in this commit and Velero still needs the permission of listing storage access key to work as expected. But as we keep the code changes, users can workaround the permission issue by refer to vmware-tanzu/velero#5984

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #173 (b49ce5e) into main (76cf020) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   14.07%   14.07%           
=======================================
  Files           4        4           
  Lines         668      668           
=======================================
  Hits           94       94           
  Misses        571      571           
  Partials        3        3           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@reasonerjt reasonerjt merged commit de5a27d into vmware-tanzu:main Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants