Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the snapshotter to support VSL credential and bump up golang #147

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

ywk253100
Copy link
Contributor

  1. Update the snapshotter to support VSL credential
  2. Bump up golang to v1.18
  3. Remove restic related

Fixes vmware-tanzu/velero#5392 Also related to vmware-tanzu/velero#5313 and vmware-tanzu/velero#5274

Signed-off-by: Wenkai Yin(尹文开) [email protected]

1. Update the snapshotter to support VSL credential
2. Bump up golang to v1.18
3. Remove restic related

Fixes vmware-tanzu/velero#5392
Also related to vmware-tanzu/velero#5313 and vmware-tanzu/velero#5274

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #147 (53ea20c) into main (f581306) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   12.88%   12.77%   -0.11%     
==========================================
  Files           4        4              
  Lines         621      626       +5     
==========================================
  Hits           80       80              
- Misses        537      542       +5     
  Partials        4        4              
Impacted Files Coverage Δ
...o-plugin-for-microsoft-azure/volume_snapshotter.go 23.39% <0.00%> (-0.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ywk253100 ywk253100 requested review from blackpiglet and reasonerjt and removed request for qiuming-best September 30, 2022 06:39
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@reasonerjt reasonerjt merged commit 96d5651 into vmware-tanzu:main Oct 12, 2022
@ywk253100
Copy link
Contributor Author

Fixes vmware-tanzu/velero#5384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

velero plugin for azure should support VSL's credential when doing snapshot
4 participants