Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new config item to volume snapshot location for Azure #140

Merged
merged 1 commit into from
May 18, 2022

Conversation

ywk253100
Copy link
Contributor

Add a new config item "tags" to the volume snapshot location for Azure

Fixes vmware-tanzu/velero#4744

Signed-off-by: Wenkai Yin(尹文开) [email protected]

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #140 (1258c5b) into main (4dff746) will increase coverage by 0.23%.
The diff coverage is 31.25%.

@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   12.64%   12.88%   +0.23%     
==========================================
  Files           4        4              
  Lines         609      621      +12     
==========================================
+ Hits           77       80       +3     
- Misses        528      537       +9     
  Partials        4        4              
Impacted Files Coverage Δ
...o-plugin-for-microsoft-azure/volume_snapshotter.go 23.77% <31.25%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dff746...1258c5b. Read the comment docs.

blackpiglet
blackpiglet previously approved these changes May 16, 2022
Add a new config item "tags" to the volume snapshot location for Azure

Fixes vmware-tanzu/velero#4744

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
@blackpiglet blackpiglet merged commit 013663b into vmware-tanzu:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure CSI Snapshots fails azure tag-policy in v1.8
4 participants