Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the environment variable when creating the custom role in README #139

Merged
merged 1 commit into from
May 13, 2022

Conversation

tbuchi888
Copy link
Contributor

@tbuchi888 tbuchi888 commented May 12, 2022

Use the environment variable AZURE_ROLE defined just before when creating the custom role in README.

Signed-off-by: Takuya Kawabuchi [email protected]

Use the environment variable `AZURE_ROLE` defined just before when creating the custom role in README.
@codecov-commenter
Copy link

Codecov Report

Merging #139 (94534a5) into main (4dff746) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   12.64%   12.64%           
=======================================
  Files           4        4           
  Lines         609      609           
=======================================
  Hits           77       77           
  Misses        528      528           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dff746...94534a5. Read the comment docs.

@jenting
Copy link
Contributor

jenting commented May 12, 2022

Please amend your commit to add signoff-by, thank you.

@tbuchi888
Copy link
Contributor Author

Hi @jenting , Thank you for your comment.
I created the PR from the Github web UI.
In the Web UI, it seems to add Signed-off-by to the Commit comment.
I don't know if this is the right way to add Commit comments,Signed-off-by.

@jenting
Copy link
Contributor

jenting commented May 12, 2022

No worries, I could manually set DCO to pass.

@tbuchi888
Copy link
Contributor Author

@jenting , Thank you for handling the matter.

@tbuchi888 tbuchi888 changed the title Use the environment variable when creating the custom role in README. Use the environment variable when creating the custom role in README May 12, 2022
@ywk253100 ywk253100 merged commit 1e14c2d into vmware-tanzu:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants