Refine the minimum permissions needed by Velero in README

[ywk253100]

Refine the minimum permissions needed by Velero in README

Signed-off-by: Wenkai Yin(尹文开) [email protected]

[ywk253100]

Fixes vmware-tanzu/velero#3154

[codecov-commenter]

Codecov Report

Merging #133 (7ec8561) into main (f287698) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   12.64%   12.64%           
=======================================
  Files           4        4           
  Lines         609      609           
=======================================
  Hits           77       77           
  Misses        528      528           
  Partials        4        4           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f287698...7ec8561. Read the comment docs.

[a-mccarthy]

@ywk253100 I think these changes look great! I am not familiar with Azure permissions, so i'd also recommend getting a second review from another maintainer/community member to have a second pair of eyes on the tech pieces of this PR.

I'm approving the changes, but have one question/suggestion. Is the information in the removed Storage account, snapshot and disk management sections still valid? I like the way the required permissions are listed out with bullet points. I think it makes the information very clear to read and scan for. If it's still correct, i'd suggest keep it in the doc right before the improved section on how to create roles and assign these permissions that you added.

You have included the information within the new content you added, so it's maybe not necessary, but it might be more clear to have it both ways for users. If it's no longer valid, then obviously it should be removed.

[ywk253100]

@ywk253100 I think these changes look great! I am not familiar with Azure permissions, so i'd also recommend getting a second review from another maintainer/community member to have a second pair of eyes on the tech pieces of this PR.

I'm approving the changes, but have one question/suggestion. Is the information in the removed Storage account, snapshot and disk management sections still valid? I like the way the required permissions are listed out with bullet points. I think it makes the information very clear to read and scan for. If it's still correct, i'd suggest keep it in the doc right before the improved section on how to create roles and assign these permissions that you added.

You have included the information within the new content you added, so it's maybe not necessary, but it might be more clear to have it both ways for users. If it's no longer valid, then obviously it should be removed.

It is still valid, I will take it back as you suggested, thanks.

[a-mccarthy]

lgtm!