-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine the minimum permissions needed by Velero in README #133
Refine the minimum permissions needed by Velero in README #133
Conversation
debf62b
to
7ec8561
Compare
Fixes vmware-tanzu/velero#3154 |
Codecov Report
@@ Coverage Diff @@
## main #133 +/- ##
=======================================
Coverage 12.64% 12.64%
=======================================
Files 4 4
Lines 609 609
=======================================
Hits 77 77
Misses 528 528
Partials 4 4 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ywk253100 I think these changes look great! I am not familiar with Azure permissions, so i'd also recommend getting a second review from another maintainer/community member to have a second pair of eyes on the tech pieces of this PR.
I'm approving the changes, but have one question/suggestion. Is the information in the removed Storage account, snapshot and disk management sections still valid? I like the way the required permissions are listed out with bullet points. I think it makes the information very clear to read and scan for. If it's still correct, i'd suggest keep it in the doc right before the improved section on how to create roles and assign these permissions that you added.
You have included the information within the new content you added, so it's maybe not necessary, but it might be more clear to have it both ways for users. If it's no longer valid, then obviously it should be removed.
It is still valid, I will take it back as you suggested, thanks. |
6048ea1
to
5e5cde3
Compare
Refine the minimum permissions needed by Velero in README Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
5e5cde3
to
9cdb37d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Refine the minimum permissions needed by Velero in README
Signed-off-by: Wenkai Yin(尹文开) [email protected]