-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle the volumes created by the CSI driver #109
Conversation
Have done some basic verifications on AKS |
Could you also test this scenario? I know this may not be completely related to csi but aws csi work is blocked by such problem, I wanna see if there's a common way to collect the AZ of the PV and put it in item backupper. |
I can reproduce the issue mentioned in vmware-tanzu/velero#4154 withe the AKS provisioned in the AZ-supported region |
55cfe60
to
54d435b
Compare
Tested with PR vmware-tanzu/velero#4350 and works well as expected |
Current VolumeSnapshotter works with volumes allocated by the "in-tree" storage driver. Kubernetes is moving to the CSI driver for Azure and will deprecate the in-tree driver, however we may not be able to get CSI snapshots in Velero to GA before that happens. As an interim solution, we handle volumes created by the CSI driver with the existing VolumeSnapshotter. Fixes vmware-tanzu/velero#4109 Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
54d435b
to
3cf14b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Current VolumeSnapshotter works with volumes allocated by the "in-tree" storage driver. Kubernetes is moving to the CSI driver for Azure and will deprecate the in-tree driver, however we may not be able to get CSI snapshots in Velero to GA before that happens. As an interim solution, we handle volumes created by the CSI driver with the existing VolumeSnapshotter. Fixes vmware-tanzu/velero#4109 Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
Current VolumeSnapshotter works with volumes allocated by the "in-tree" storage driver. Kubernetes is moving to the CSI driver for Azure and will deprecate the in-tree driver, however we may not be able to get CSI snapshots in Velero to GA before that happens. As an interim solution, we handle volumes created by the CSI driver with the existing VolumeSnapshotter.
Fixes vmware-tanzu/velero#4109
Signed-off-by: Wenkai Yin(尹文开) [email protected]