Handle the volumes created by the CSI driver #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have done some basic verifications on AKS |
reasonerjt
reviewed
Nov 5, 2021
reasonerjt
reviewed
Nov 5, 2021
|
Could you also test this scenario? I know this may not be completely related to csi but aws csi work is blocked by such problem, I wanna see if there's a common way to collect the AZ of the PV and put it in item backupper. |
I can reproduce the issue mentioned in vmware-tanzu/velero#4154 withe the AKS provisioned in the AZ-supported region |
ywk253100
force-pushed
the
211103_csi
branch
2 times, most recently
from
55cfe60 to
54d435b
Compare
|
Tested with PR vmware-tanzu/velero#4350 and works well as expected |
reasonerjt
reviewed
Nov 17, 2021
Current VolumeSnapshotter works with volumes allocated by the "in-tree" storage driver. Kubernetes is moving to the CSI driver for Azure and will deprecate the in-tree driver, however we may not be able to get CSI snapshots in Velero to GA before that happens. As an interim solution, we handle volumes created by the CSI driver with the existing VolumeSnapshotter. Fixes vmware-tanzu/velero#4109 Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
ywk253100
force-pushed
the
211103_csi
branch
from
54d435b to
3cf14b6
Compare
zubron
approved these changes
Nov 19, 2021
yvespp
pushed a commit
to yvespp/velero-plugin-for-microsoft-azure
that referenced
this pull request
May 9, 2022
Current VolumeSnapshotter works with volumes allocated by the "in-tree" storage driver. Kubernetes is moving to the CSI driver for Azure and will deprecate the in-tree driver, however we may not be able to get CSI snapshots in Velero to GA before that happens. As an interim solution, we handle volumes created by the CSI driver with the existing VolumeSnapshotter. Fixes vmware-tanzu/velero#4109 Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current VolumeSnapshotter works with volumes allocated by the "in-tree" storage driver. Kubernetes is moving to the CSI driver for Azure and will deprecate the in-tree driver, however we may not be able to get CSI snapshots in Velero to GA before that happens. As an interim solution, we handle volumes created by the CSI driver with the existing VolumeSnapshotter.
Fixes vmware-tanzu/velero#4109
Signed-off-by: Wenkai Yin(尹文开) [email protected]