Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the volumes created by the CSI driver #109

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

ywk253100
Copy link
Contributor

Current VolumeSnapshotter works with volumes allocated by the "in-tree" storage driver. Kubernetes is moving to the CSI driver for Azure and will deprecate the in-tree driver, however we may not be able to get CSI snapshots in Velero to GA before that happens. As an interim solution, we handle volumes created by the CSI driver with the existing VolumeSnapshotter.

Fixes vmware-tanzu/velero#4109

Signed-off-by: Wenkai Yin(尹文开) [email protected]

@ywk253100
Copy link
Contributor Author

Have done some basic verifications on AKS

@reasonerjt
Copy link
Contributor

Could you also test this scenario?
vmware-tanzu/velero#4154

I know this may not be completely related to csi but aws csi work is blocked by such problem, I wanna see if there's a common way to collect the AZ of the PV and put it in item backupper.

@ywk253100
Copy link
Contributor Author

Could you also test this scenario? vmware-tanzu/velero#4154

I know this may not be completely related to csi but aws csi work is blocked by such problem, I wanna see if there's a common way to collect the AZ of the PV and put it in item backupper.

I can reproduce the issue mentioned in vmware-tanzu/velero#4154 withe the AKS provisioned in the AZ-supported region

@ywk253100 ywk253100 force-pushed the 211103_csi branch 2 times, most recently from 55cfe60 to 54d435b Compare November 16, 2021 02:20
@ywk253100
Copy link
Contributor Author

Tested with PR vmware-tanzu/velero#4350 and works well as expected

Current VolumeSnapshotter works with volumes allocated by the "in-tree" storage driver. Kubernetes is moving to the CSI driver for Azure and will deprecate the in-tree driver, however we may not be able to get CSI snapshots in Velero to GA before that happens. As an interim solution, we handle volumes created by the CSI driver with the existing VolumeSnapshotter.

Fixes vmware-tanzu/velero#4109

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zubron zubron merged commit 15330f9 into vmware-tanzu:main Nov 19, 2021
yvespp pushed a commit to yvespp/velero-plugin-for-microsoft-azure that referenced this pull request May 9, 2022
Current VolumeSnapshotter works with volumes allocated by the "in-tree" storage driver. Kubernetes is moving to the CSI driver for Azure and will deprecate the in-tree driver, however we may not be able to get CSI snapshots in Velero to GA before that happens. As an interim solution, we handle volumes created by the CSI driver with the existing VolumeSnapshotter.

Fixes vmware-tanzu/velero#4109

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update velero-plugin-for-microsoft-azure to handle volumes created by the Azure CSI driver
3 participants