Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): build on node 16 (current) #3098

Merged
merged 1 commit into from
Apr 22, 2021
Merged

chore(ci): build on node 16 (current) #3098

merged 1 commit into from
Apr 22, 2021

Conversation

nihalgonsalves
Copy link
Member

Description

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Apr 22, 2021
@patak-dev patak-dev merged commit 5fe9a69 into vitejs:main Apr 22, 2021
@nihalgonsalves nihalgonsalves deleted the ng/node-16 branch April 22, 2021 20:20
@nihalgonsalves nihalgonsalves mentioned this pull request Apr 23, 2021
Closed
TobiasMelen pushed a commit to TobiasMelen/vite that referenced this pull request May 3, 2021
@nihalgonsalves @TobiasMelen
ci: build on node 16 (current) (vitejs#3098)
61fbc8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nihalgonsalves @patak-dev @Shinigami92