test(setup): fix server closure

[nihalgonsalves]

Description

Attempt to fix test teardown issues.

The current failures can be reliably reproduced using:

yarn test-serve packages/playground/ssr-vue/__tests__/ssr-vue.spec.ts --detectOpenHandles

This fixes that case.

Additional context

Fixes these errors:

ReferenceError: You are trying to `import` a file after the Jest environment has been torn down.

Cannot log after tests are done. Did you forget to wait for something async in your test?

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[Shinigami92]

I think you can shorten this to

Suggested change

	await new Promise((resolve) => {
	server.close(resolve)
	})
	if (vite) {
	await vite.close()
	}
	await new Promise((resolve) => server.close(resolve))
	await vite?.close()

[nihalgonsalves]

I didn't use an optional chain because of pre-Node-14 environments – is this file transpiled by Jest?

[Shinigami92]

ah okay, I'm so used to TypeScript ^^

[patak-dev]

Failed on windows because of the 30000 ms general jest timeout, we should bump it to 40000 at least. We may do that in another PR

[Shinigami92]

On the windows runner there was an error https://github.com/vitejs/vite/pull/3056/checks?check_run_id=2384573026#step:10:29

FAIL packages/playground/ssr-react/__tests__/ssr-react.spec.ts
  ● Test suite failed to run

    Timeout - Async callback was not invoked within the 30000 ms timeout specified by jest.setTimeout.Error: Timeout - Async callback was not invoked within the 30000 ms timeout specified by jest.setTimeout.

      at mapper (node_modules/jest-jasmine2/build/queueRunner.js:27:45)

---

@patak-js 30s are already very high, isn't it? 🤔

[patak-dev]

Looks like 30 sec is not enough, no?

[Shinigami92]

Looks like 30 sec is not enough, no?

But what is it waiting for? Will this occur in real production environment?
Will humans want to wait so long? Or think that something hung up?

[Shinigami92]

Hey I will re-run the job and look if the windows runner fails with the same timeout-issue

---

Works ✔️

[patak-dev]

@nihalgonsalves since checks have passed, I think you could make this one ready for review and work on further improvements in another PR

[brillout]

@nihalgonsalves Thanks this has been quite a pain ❤️ CC @dominikg