Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct line for less errors #14381

Closed
wants to merge 1 commit into from
Closed

fix: correct line for less errors #14381

wants to merge 1 commit into from

Conversation

HigherOrderLogic
Copy link

Description

Closes #14312

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Sep 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy
Copy link
Member

bluwy commented Sep 15, 2023

Are you sure this fixes the issue? #14312 (comment) mentions to + 1 the column, not the line. Can you show a before and after error message of the change?

@HigherOrderLogic
Copy link
Author

Are you sure this fixes the issue? #14312 (comment) mentions to + 1 the column, not the line. Can you show a before and after error message of the change?

image

I'm pretty sure this PR fixes the issue.

@bluwy
Copy link
Member

bluwy commented Sep 15, 2023

I don't think that caret is pointing in the right place either, it's outside of the column?

@HigherOrderLogic
Copy link
Author

I don't think that caret is pointing in the right place either, it's outside of the column?

Maybe that's intended? When I edit to column: error.column + 1, the caret point to the i of @import.

@bluwy
Copy link
Member

bluwy commented Sep 17, 2023

Pointing at the i of @import looks more correct as it's the import statement that's failing, although not completely accurate too perhaps. Maybe worth testing different kinds of less errors and check if the changes are correct?

Otherwise, I'd still opt to bumping the column instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caret in on-screen error output points to the wrong line
2 participants