Update sev library dependency and minor version #123
Conversation
Signed-off-by: Tyler Fanelli <[email protected]>
Signed-off-by: Tyler Fanelli <[email protected]>
| @@ -49,7 +49,7 @@ mod set { | |||
|
|
|||
| pub fn set_config(args: Args) -> Result<()> { | |||
| // Create Tcb with provided values | |||
| let tcb = TcbVersion::new(args.bootloader, args.tee, args.snp_fw, args.microcode); | |||
| let tcb = TcbVersion::new(None, args.bootloader, args.tee, args.snp_fw, args.microcode); | |||
There was a problem hiding this comment.
@larrydewey @DGonzalezVillal I've set this to None as we don't currently have a way for the user to specify the FMC firmware version. Is this alright for now?
There was a problem hiding this comment.
So we found out that Turin has this new fmc TCB value, so if the machine is a turin then fmc is present. We originally thought this was being brought in a new fw, but apparently this has always been the case.
There was a problem hiding this comment.
So what should a user set the value to be? Where would they find the relevant FMC data?
There was a problem hiding this comment.
So, FMC is one of the fields added to the Turin+ TCB structures. With the library changes we implemented, I believe that whenever the TCB is checked, it will verify the CPU model version and populate the correct structure accordingly. If a user runs snphost ok, they should be able to see their current TCB version.
The expected behavior here is that if a user provides an FMC value, the library should automatically determine whether the TCB structure includes it. If the CPU is Turin or newer, the value should be set; if it is Genoa or Milan, the input should either be ignored or return an error.
The value should be of type u8.
No description provided.