fix: add missing CLI option to argv parser #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
help message and types for the request logging option were updated, but the argument parser option wasn't.
|
I was going to open the same PR right now, then I saw it was already open :) |
gamemaker1
approved these changes
Nov 9, 2022
ghost
approved these changes
Nov 9, 2022
livinglogic-nl
approved these changes
Nov 10, 2022
|
Can we get this merge please? |
|
Issue #744 is holding back our project. Would appreciate if this PR can be reviewed/approved soon. Thanks. |
|
@rohan-kadkol my temporary fork here: https://www.npmjs.com/package/jsbrain_serve ... not sure about your compliance though if you try to deploy to production. |
@rohan-kadkol you can probably use https://www.npmjs.com/package/patch-package and apply @casperx 's fix to get you unblocked |
AndyBitz
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
help message and types for the request logging option were updated, but the argument parser option wasn't. When the user specifies
-L,--no-request-loggingas specified in the help message, argument parser throwsArgError: unknown or unexpected option.