Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI #137

Closed
wants to merge 32 commits into from
Closed

Update CI #137

wants to merge 32 commits into from

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented Feb 19, 2024

@ptoffy ptoffy marked this pull request as ready for review February 19, 2024 19:15
@ptoffy ptoffy requested review from 0xTim and gwynne as code owners February 19, 2024 19:15
@ptoffy ptoffy added this to the v5 milestone Feb 19, 2024
@0xTim
Copy link
Member

0xTim commented Feb 20, 2024

@ptoffy we can merge this if it's only the SIWA integration test failing

@ptoffy ptoffy linked an issue Feb 21, 2024 that may be closed by this pull request
Enable Warnings as Errors in CI #133
Closed
@0xTim 0xTim changed the base branch from jwtkit-5 to main February 21, 2024 18:09
@0xTim
Copy link
Member

0xTim commented Feb 22, 2024

@ptoffy this will need rebasing

gwynne
gwynne requested changes Feb 23, 2024
View reviewed changes
.github/workflows/test.yml Outdated
@@ -25,7 +25,7 @@ jobs:
- name: Use local JWTKit
run: swift package --package-path jwt edit jwt-kit --path ./jwt-kit
- name: Run tests with Thread Sanitizer
run: swift test --package-path jwt --sanitize=thread
run: swift test --package-path jwt --sanitize=thread -Xswiftc -warnings-as-errors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good way to make sure CI never ever passes, given the way warnings tend to show up without warning (no pun intended) thanks to changes in dependencies.

ptoffy and others added 20 commits February 24, 2024 22:21
@ptoffy
Move away from BoringSSL (#99)
6e1f21f 
* Start moving away from BoringSSL

* Start converting RSA

* Update RSA signer

* Some fixes

* Add possible RSA pubkey creation algorithm

* Add prime number generator with Miller-Rabin test

* Prime generation performance improvement

* Attempt at private key calculation

* RSA prime generation take 2

* API tidy up

* Performance improvements

* Even more speed

* RSA tidy up

* Fix JWTSigner with new RSA impl

* Add RSA tests and polish some stuff

* Remove unused method

* Minor improvements

* Add GCD test

* Get ECDSA compiling

* Add key gen test + fixups

* Add RSA cert support + enforce bigger key sizes

* Start adding ECDSA tests

* Generify ECDSAKey

* Abstract more and add P384 and P521 keys

* Adapt curve sizes

* Fix some tests

* Base64URL decode raw key elements

* Update byteRange names

* Remove BoringSSL

* Update error description

* Fix wrong overload resolution

* Add padding option for RSA signer

* Update platform versions and start converting X5C

* Convert X5CVerifier and X5CTests (SHA256)

* Add certificate creation scripts

* Fix comment

* Address most requested issues

* Add docs and replace struct with tuple

* Remove valid X5C print statement

* Remove `rsa_oaep_misc_test` test vectors

* Performance improvements

* Remove unused files

* Apply suggestions

* 🤦‍♂️

* Minor fixes

* Refactor RSA init

* Make RSAKey a struct and update docs
@ptoffy
Implement JWTKeyCollection and hide JWTSigner (#111)
793d629 
* Implement `JWTKeyCollection` and hide `JWTSigner`

* Make `JWTSigner` `Sendable`

* Add comments and remove unused method

* Add warning when overwriting kid

* Remove `JWTSigners`

* Make `JWKSigner` `Sendable`

* Cleanups

* Update DocC comments

* Minor improvements
@ptoffy
Add RSA pre-generated token test (#114)
a9c321d 
Add RS256 pre-generated token test
@gwynne @ptoffy
Enable full CI on the 5.x branch
3cfc809
@gwynne @ptoffy
Skip API breakage check for 5.x branch for now
b97bbff
@ptoffy @gwynne
Add Sendable support (#116)
d4f583f 
* Add `Sendable` support

* Add Sendable conformance to tests

* Make X5CVerifier a struct

---------

Co-authored-by: Gwynne Raskind <[email protected]>
@ptoffy
Rename ES521 to ES512
4708610
@ptoffy
Rename signer to algorithm
2b9f37a
@ptoffy
Add support for custom time validation X5Cs (#119)
52b178e 
* Add support for custom time validation X5Cs

* Clean up and move JSONDecoder settings out of X5C

* Add more assertions in new X5C test

* Refactor X5CTests
@ptoffy
Add ECDSAKey PEM export (#120)
3513902 
* Add ECDSAKey PEM export

* Use public key from private when possible

* Refactor ECDSAKey init
@ptoffy
Remove exports (#121)
f21ab2d 
Start removing exports
@ptoffy
Adopt package access and add RSA key PEM export (#122)
7ca0be6 
* Adopt `package` access and add RSA key PEM export

* Remove unused code

* Make equatable conformance public

* Optimise RSAKey Equatable implementation
@ptoffy
Refactor RSAKey Equatable implementation
82549b6
@ptoffy @gwynne
Remove public enums (#123)
33f0278 
* Start removing enums

* Update JWTError

* Add custom decoding for new structs

* Adopt a more structured JWTError

* Minor improvements

* Test integration with v5 of JWT

* Make JWK use existing curves

* Nit: spacing

---------

Co-authored-by: Gwynne Raskind <[email protected]>
@ptoffy
Remove use of Data(contentsOf:)
cb4fc4f
@MFranceschi6 @ptoffy
Add RSA-PSS signature algorithm support (#112)
5f58f56 
* Add RSA-PSS signature algorithm support

* Add PSS signers and tests

* Replace `Data(contentsOf:)` with `URLSession`

* Remove Apple jwks test

* Fix keycollection's getSigner method

* Fix keycollection's getSigner method

---------

Co-authored-by: Paul <[email protected]>
@ptoffy
Adjust JWTError access modifiers
49d0fbb
@ptoffy
Adjust JWTError access modifiers once again
4004865
@ptoffy
Add option to sign tokens with x5c chains (#126)
c6d3efd 
* Add option to sign tokens with x5c chains

* Add new test and fixes
@ptoffy
Add option to fetch RSA primitives (#127)
f100346 
* Add option to fetch RSA primitives

* Typo

* Remove unused files

* Update NOTICES
ptoffy and others added 12 commits February 24, 2024 22:21
@ptoffy
Split internal key structure into public and private (#128)
b536371 
* Create first idea of split RSA keys

* Refactor signer and update docs

* Split ECDSA keys

* Remove useless parameter

* Update EdDSA

* Rename file

* Adjust spacing

* Remove useless implementations

* Clean up some access modifiers

* Move RSA to insecure namespace
@ptoffy
Add customisable fields to JWTHeader (#129)
0e5607e 
* Add customisable fields to JWTHeader

* Remove unused field

* Fix en/decoding logic and add remove `package` use

* Make customFields not optional

* Add correct init to JWTHeader

* Fix CodingKey mismatch

* Remove `CaseIterable` conformance

* Fix
@ptoffy
Add float jwt header field type
81cb28e
@ptoffy
Allow for custom JWT de/serialisation (#130)
9921a3f 
* Improve header structure

* Allow for custom JWT de/serialisation

* Make properties return nil instead of throwing

* Make the new API easier to use

* Add platform-agnostic de/compression algorithms

* Remove unnecessary test
@ptoffy
Update swift-certificates and add customisable policy to X5C verifica…
593c614 
…tion
@ptoffy
Add key initialiser for SwiftCrypto key types
1b543d4
@ptoffy
Add missingX5CHeader error
e2dcbc5
@ptoffy
Add RSA size boundary (#135)
a9bfd79 
Add 2048 bits key size boundary for RSA keys
@ptoffy
Treat warnings as errors
a62e9ac
@ptoffy
Add benchmark CI
048ff9a
@ptoffy @gwynne
Update .github/workflows/benchmark.yml
7fc00f4 
Co-authored-by: Gwynne Raskind <[email protected]>
@ptoffy
Remove error on warning option
84555f7
@ptoffy ptoffy closed this Feb 24, 2024
@ptoffy ptoffy deleted the update-ci branch February 24, 2024 22:25
@ptoffy
Copy link
Member Author

ptoffy commented Feb 24, 2024

Closed in favour of #141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne requested changes

@0xTim 0xTim 0xTim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5
Development

Successfully merging this pull request may close these issues.

Enable Warnings as Errors in CI
4 participants
@ptoffy @0xTim @gwynne @MFranceschi6