Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Google emojis #95

Merged
merged 6 commits into from
Feb 23, 2017
Merged

Add support for Google emojis #95

merged 6 commits into from
Feb 23, 2017

Conversation

rubengees
Copy link
Collaborator

This adds support for google emojis by introducting the new module emoji-google.
I added the target to the generator and also updated the sample app for it.

One noteworthy change is the possibility to ignore individual emojis when generating. This was needed, because Google had some weird question mark flags, which I added to the new ignore list by hand.

@codecov-io
Copy link

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   24.96%   24.96%           
=======================================
  Files          19       19           
  Lines         629      629           
  Branches       67       67           
=======================================
  Hits          157      157           
  Misses        459      459           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 680710f...ddc6531. Read the comment docs.

Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍 any plans on adding more modules / providers?

@vanniktech vanniktech merged commit 852ca0c into vanniktech:master Feb 23, 2017
@rubengees
Copy link
Collaborator Author

We could also have Twitter, Facebook, Facebook Messenger (Those are different), Samsung and Windows.
I don't know if all of those make sense though, since they are not that widely used. What do you think we should also include?

@rubengees rubengees deleted the google-emojis branch February 23, 2017 20:08
@rubengees
Copy link
Collaborator Author

You can find a list of the different variants here. This is the file we use for parsing, so exactly those images would be in the lib.

@vanniktech
Copy link
Owner

Hmm the only thing that might make sense to me personally is the facebook messer emojis. But then again if it's for free, why not provide all of them?

@rubengees
Copy link
Collaborator Author

Yes, thats true. I will work on another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants