-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Google emojis #95
Conversation
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
=======================================
Coverage 24.96% 24.96%
=======================================
Files 19 19
Lines 629 629
Branches 67 67
=======================================
Hits 157 157
Misses 459 459
Partials 13 13 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👍 any plans on adding more modules / providers?
We could also have |
You can find a list of the different variants here. This is the file we use for parsing, so exactly those images would be in the lib. |
Hmm the only thing that might make sense to me personally is the facebook messer emojis. But then again if it's for free, why not provide all of them? |
Yes, thats true. I will work on another PR. |
This adds support for google emojis by introducting the new module
emoji-google
.I added the target to the
generator
and also updated the sample app for it.One noteworthy change is the possibility to ignore individual emojis when generating. This was needed, because Google had some weird question mark flags, which I added to the new ignore list by hand.