Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove View parameter from OnEmojiBackspaceClickListener interface. #621

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Remove View parameter from OnEmojiBackspaceClickListener interface. #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/com/vanniktech/emoji/sample/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ public class MainActivity extends AppCompatActivity {

private void setUpEmojiPopup() {
emojiPopup = EmojiPopup.Builder.fromRootView(rootView)
.setOnEmojiBackspaceClickListener(ignore -> Log.d(TAG, "Clicked on Backspace"))
.setOnEmojiBackspaceClickListener(() -> Log.d(TAG, "Clicked on Backspace"))
.setOnEmojiClickListener(emoji -> Log.d(TAG, "Clicked on Emoji " + emoji.getUnicode()))
.setOnEmojiPopupShownListener(() -> emojiButton.setImageResource(R.drawable.ic_keyboard))
.setOnSoftKeyboardOpenListener(ignore -> Log.d(TAG, "Opened soft keyboard"))
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/com/vanniktech/emoji/sample/MainDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ private View buildView() {

private void setUpEmojiPopup() {
emojiPopup = EmojiPopup.Builder.fromRootView(rootView)
.setOnEmojiBackspaceClickListener(ignore -> Log.d(TAG, "Clicked on Backspace"))
.setOnEmojiBackspaceClickListener(() -> Log.d(TAG, "Clicked on Backspace"))
.setOnEmojiClickListener(emoji -> Log.d(TAG, "Clicked on Emoji " + emoji.getUnicode()))
.setOnEmojiPopupShownListener(() -> emojiButton.setImageResource(R.drawable.ic_keyboard))
.setOnSoftKeyboardOpenListener(ignore -> Log.d(TAG, "Opened soft keyboard"))
Expand Down
2 changes: 1 addition & 1 deletion emoji/src/main/java/com/vanniktech/emoji/EmojiView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ private void handleEmojiTabs(
}

if (onEmojiBackspaceClickListener != null) {
onEmojiBackspaceClickListener.onEmojiBackspaceClick(view);
onEmojiBackspaceClickListener.onEmojiBackspaceClick();
}
}));
}
Expand Down
4 changes: 1 addition & 3 deletions emoji/src/main/java/com/vanniktech/emoji/listeners/OnEmojiBackspaceClickListener.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
*/
package com.vanniktech.emoji.listeners

import android.view.View

interface OnEmojiBackspaceClickListener {
fun onEmojiBackspaceClick(v: View)
fun onEmojiBackspaceClick()
}