Only construct RecentEmojiManager if one hasn’t already been set #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
previously approved these changes
Oct 26, 2020
vanniktech
approved these changes
Oct 26, 2020
mario
approved these changes
Oct 26, 2020
Can do in a separate PR. |
The main reason for extracting this one out was the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #476 - Previously the
RecentEmojiManagerwas being constructed when the builder was created. This PR changes the buildersrecentEmojifield to @nullable and performs the initialisation when build is called. This way people can set their own emoji managers and manage the threading of any disk reads in whatever way suits them.