Add shortcodes to emojis #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
previously approved these changes
Jun 1, 2020
|
Isn't a shortcode supposed to be prefixed with ":" ? |
|
Also how does slack know that
|
|
Slack is wrong because an ant is not a bug xD |
|
@vanniktech You're right, there can actually be more (and our datasource has them)! I'll change it so we have a @mario The ":" prefix is a markup convention which is used to detect emojis in text. It's not part of any standard I think. |
vanniktech
approved these changes
Jun 3, 2020
|
Thanks @rubengees 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new field with the shortcode to the
Emojiclass. Accordingly the generator has been extended.This does not implement any UI or herlper methods yet.