Update generator for Unicode 12.1 #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comes with some significant changes since the generated code as the structure was before could not be compiled. We now chunk the emojis into configurable lists which each get a class in the style of ActivitiesCategoryChunk0. Also, the categories have changed a bit, so these get now normalized to what we had before. Finally this fixes a bug causing low(er) image quality.
rubengees
commented
Feb 2, 2020
| const maxY = emojiByStrip[i].map(it => it.sheet_y).reduce((a, b) => Math.max(a, b), 0); | ||
| const height = (maxY + 1) * 66; | ||
| const strip = await new Jimp(66, height); | ||
| await strip.blit(sheet, 0, 0, i * 66, 0, 66, height); |
There was a problem hiding this comment.
This was the cause of lower quality images.
rubengees
commented
Feb 2, 2020
| const maxY = emojiByStrip[i].map(it => it.sheet_y).reduce((a, b) => Math.max(a, b), 0); | ||
| const height = (maxY + 1) * 66; | ||
|
|
||
| const strip = await sheet.clone().crop(i * 66, 0, 66, height) |
There was a problem hiding this comment.
We now simply crop.
rubengees
commented
Feb 2, 2020
|
|
||
| result.set("SmileysAndPeople", smileysAndEmotion.concat(peopleAndBody)) | ||
| result.delete("SmileysAndEmotion") | ||
| result.delete("PeopleAndBody") |
There was a problem hiding this comment.
Our upstream source slightly changed the categories. Here we normalize them back to what we had previously.
rubengees
commented
Feb 2, 2020
|
|
||
| await fs.writeFile(`${dir}/${target.name}.java`, _(emojiTemplate).template()({ | ||
| await fs.writeFile(`${valuesDir}/strings.xml`, template(stringsTemplate)({ |
There was a problem hiding this comment.
We now also generate the strings.xml file automatically.
|
I have added the generated files and will merge once CI passes and @mario approves 🙂. |
|
Approved by Mario (tm) |
mario
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bigger overhaul of the generator to support the latest changes to our data source among other things:
This comes with a significant change how we generate the categories. Due to too many icons being present now we started to run into "code too large" exceptions. I have changed the generator so that it generates "chunk" classes of 250 emojis at most and concats them together in the actual category.
Before:
Now:
As always this PR comes without the generated code to make review easier.
Would close #344 and #356.