Add emoji-material module for material bindings. #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
commented
Oct 3, 2019
| @@ -216,7 +216,7 @@ Pattern getEmojiRepetitivePattern() { | |||
| return emojiMap.get(candidate.toString()); | |||
| } | |||
|
|
|||
| void verifyInstalled() { | |||
| public void verifyInstalled() { | |||
There was a problem hiding this comment.
Not happy about this but required :(
mario
reviewed
Oct 3, 2019
mario
reviewed
Oct 3, 2019
|
Looks decent, but are we copy/pasting too much code between material and regular widgets? Can that be unified? |
I've tried 1-2 years ago and I gave up. Can try again but can be a follow up PR. |
|
Never give up :P Needs rebase, then I can approve. |
|
Done so |
mario
approved these changes
Oct 3, 2019
|
Waiting for @rubengees's code review |
rubengees
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step. LayoutFactory will follow.