Support use case where only Emoji Dialog should be shown. #378
Conversation
|
Ooook. |
|
|
||
| /** Forces that only Emojis are allowed as input. */ | ||
| public void forceEmojisOnly(final EmojiPopup emojiPopup) { | ||
| setOnFocusChangeListener(new ForceEmojisOnlyFocusChangeListener(emojiPopup)); |
There was a problem hiding this comment.
This doesn't do what the method name suggests, it shows the popup once the EditText is focused instead.
There was a problem hiding this comment.
So showsEmojisOnly. With this approach, there's no way to get to the normal keyboard though and insert normal characters.
There was a problem hiding this comment.
Ah now I get what this is supposed to do! I got confused since I thought this method should control if the OnlyEmojisInputFilter should be applied or not, but it's something else.
Maybe a name like disableKeyboardInput or something would be more clear?
There was a problem hiding this comment.
If we add this, we may want a method to revert this behavior e.g. remove the OnFocusListener.
| import android.text.Spanned; | ||
| import androidx.annotation.Nullable; | ||
|
|
||
| public final class OnlyEmojisInputFilter implements InputFilter { |
There was a problem hiding this comment.
This is also present in the other PR, did you mix these up?
vanniktech
force-pushed
the
ForceEmojis
branch
from
108aef0 to
0ed1735
Compare
vanniktech
force-pushed
the
ForceEmojis
branch
from
0ed1735 to
bef7399
Compare
|
This is ready now @mario & @rubengees |
|
Waiting for @mario's review. |
No description provided.