Make EmojiManager's initialization methods synchronized #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
previously approved these changes
May 30, 2019
|
Sorry, for the noise @vanniktech, I had problems getting the static code analysis tools to accept these changes 😁 |
|
Looks decent :D |
vanniktech
approved these changes
May 30, 2019
vanniktech
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods are all operating on the static
INSTANCEfield and are modifying it, creating race conditions. While in practice this should never happen (installshould be called synchronously inonCreate), I have a specific use case which requires synchronization: Async installation. If not synchronized, a call could happen directly afterinstall, throwing an Exception, because the installation is not done yet.