Add support for custom ViewPager.PageTransformer. #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mario
requested review from
vanniktech and
rubengees
and removed request for
vanniktech
|
Please note that this PR adds a dependency to the APP (not the LIBRARY) so we could showcase how it works without having to write a real page transformer. As such, I don't think having it as a dependency is a burden. |
vanniktech
previously approved these changes
Jan 27, 2019
| @@ -63,6 +63,8 @@ dependencies { | |||
| implementation rootProject.ext.supportRecyclerView | |||
| implementation rootProject.ext.supportEmojiBundled | |||
|
|
|||
| implementation 'com.eftimoff:android-viewpager-transformers:1.0.1@aar' | |||
mario
force-pushed
the
add-viewpager-transformer
branch
from
fad9fb3 to
90e08d6
Compare
|
Updated and rebased. |
|
Needs a rebase. |
Signed-off-by: Mario Danic <[email protected]>
Signed-off-by: Mario Danic <[email protected]>
Signed-off-by: Mario Danic <[email protected]>
Signed-off-by: Mario Danic <[email protected]>
Signed-off-by: Mario Danic <[email protected]>
Signed-off-by: Mario Danic <[email protected]>
Signed-off-by: Mario Danic <[email protected]>
mario
force-pushed
the
add-viewpager-transformer
branch
from
90e08d6 to
bbedb14
Compare
|
Done. |
vanniktech
changed the title
vanniktech
approved these changes
Jan 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that this PR builds on top of #333.