Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release method which releases the sheet but not the data structure #266

Merged
merged 3 commits into from
Mar 10, 2018
Merged

Add release method which releases the sheet but not the data structure #266

merged 3 commits into from
Mar 10, 2018

Conversation

rubengees
Copy link
Collaborator

This is from a personal use case which I can imagine is also relevant for others.

In my application, I want to release the heavy sheet Bitmap after leaving the relevant Activity but keep the emoji datastructure in memory to still have good performance when opening the Activity again. When using the existing destroy method, I would have to install a provider each time the Activity is opened, which blocks the main thread and causes a visible stutter in my case. This new release method allows to release the Bitmap when leaving and still installing the Provider once in a central place.

@codecov
Copy link

codecov bot commented Mar 9, 2018

Codecov Report

Merging #266 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   28.48%   28.65%   +0.17%     
==========================================
  Files          22       22              
  Lines         825      827       +2     
  Branches       90       90              
==========================================
+ Hits          235      237       +2     
  Misses        571      571              
  Partials       19       19
Impacted Files Coverage Δ
...c/main/java/com/vanniktech/emoji/EmojiManager.java 86.9% <100%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4965f3...247cdfe. Read the comment docs.

Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some javadoc?

@rubengees
Copy link
Collaborator Author

Sure! Give me a monent.

@rubengees
Copy link
Collaborator Author

Done!

@vanniktech vanniktech merged commit 1987aa7 into vanniktech:master Mar 10, 2018
@vanniktech
Copy link
Owner

Thanks once again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants