Remove Global Layout listener when dismissing the popup. Fixes #22 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 46.95%@@ master #24 diff @@
==========================================
Files 20 21 +1
Lines 2435 2441 +6
Methods 0 0
Messages 0 0
Branches 62 63 +1
==========================================
+ Hits 1144 1146 +2
- Misses 1283 1287 +4
Partials 8 8 |
vanniktech
force-pushed
the
master_global_layout_fix
branch
from
a16e1d1 to
6984ce5
Compare
Handle deprecation of removeGlobalOnLayoutListener Fix checkstyle errors
vanniktech
force-pushed
the
master_global_layout_fix
branch
from
6984ce5 to
f15cdb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GreenSkinMonster mind taking a look at this?