Obey library loading state and add modifiers only where needed #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
=======================================
Coverage 27.93% 27.93%
=======================================
Files 22 22
Lines 809 809
Branches 88 88
=======================================
Hits 226 226
Misses 565 565
Partials 18 18Continue to review full report at Codecov.
|
|
I'll look at this PR shortly. I'm rather busy at the moment. |
|
This has some of the things also from #198, right? If so I'd say let's focus on one PR first and let's do the other one. Feel free to choose with which we should start. |
|
This is a clean subset of #198, so ideally we'd do this first. 199 contains some unrelated things that are probably better handled as separate PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a strict subset of my other pull request, which also adds support library span handling. The purpose is to simplify the review process and to separate concerns.
It addresses two issues
EmojiCompat span replacement routines are now only called when the library is ready. Before, an exception might be thrown if emojis were used at an earlier point of time.
The emoji style modifler is added explicitly in the data where needed by the emoji support library. Before, it was added using an incomplete "rule of thumb" in the drawable. The previous approach was incorrect, overly broad and won't work if the whole text replacement is handled by the library.