Kotlin module #147
Kotlin module #147
Conversation
Some small fixes.
build.gradle
Outdated
| @@ -12,6 +12,7 @@ codeQualityTools { | |||
| } | |||
|
|
|||
| buildscript { | |||
| ext.kotlin_version = '1.1.2-5' | |||
emoji-kotlin/build.gradle
Outdated
| } | ||
|
|
||
| apply from: rootProject.file('gradle/gradle-mvn-push.gradle') | ||
| repositories { |
emoji-kotlin/proguard-rules.pro
Outdated
| # You can edit the include path and order by changing the proguardFiles | ||
| # directive in build.gradle. | ||
| # | ||
| # For more details, see |
|
Not sure what's wrong with Travis:
|
Fix issue
Trying to exclude Kotlin classes from generated javadoc
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
=======================================
Coverage 27.93% 27.93%
=======================================
Files 22 22
Lines 809 809
Branches 89 89
=======================================
Hits 226 226
Misses 565 565
Partials 18 18Continue to review full report at Codecov.
|
emoji-kotlin/build.gradle
Outdated
| resourcePrefix 'emoji' | ||
|
|
||
| sourceSets { | ||
| main.java.srcDirs += 'src/main/kotlin' |
There was a problem hiding this comment.
Can you just do everything in src/main/java?
| @@ -85,6 +85,7 @@ afterEvaluate { project -> | |||
| task androidJavadocs(type: Javadoc) { | |||
| source = android.sourceSets.main.java.srcDirs | |||
| classpath += project.files(android.getBootClasspath().join(File.pathSeparator)) | |||
| excludes = ['**/*.kt'] | |||
There was a problem hiding this comment.
Yes, basically ignoring Kotlin files for javadoc generation.
Added extra extensions.
Added Kotlin module containing 2 extensions functions over String.
TODO: Modify the readme accordingly.