fix: catch exceptions from detach calls #20656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caalador
reviewed
Dec 10, 2024
mcollovati
reviewed
Dec 10, 2024
There was a problem hiding this comment.
Looks good. The only concern is that this could be some sort of behavioral breaking change, since it doesn't break the application as before, but it "silently" continues the execution (although errors should be logged, unless a custom error handler suppresses them).
It would probably be good to highlight the change in the release notes.
|
caalador
approved these changes
Dec 13, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
* fix: catch exceptions from detach calls * add test --------- Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
* fix: catch exceptions from detach calls * add test --------- Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
* fix: catch exceptions from detach calls * add test --------- Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot
added a commit
that referenced
this pull request
Dec 13, 2024
* fix: catch exceptions from detach calls * add test --------- Co-authored-by: Teppo Kurki <[email protected]> Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot
added a commit
that referenced
this pull request
Dec 13, 2024
* fix: catch exceptions from detach calls * add test --------- Co-authored-by: Teppo Kurki <[email protected]> Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot
added a commit
that referenced
this pull request
Dec 13, 2024
* fix: catch exceptions from detach calls * add test --------- Co-authored-by: Teppo Kurki <[email protected]> Co-authored-by: Marco Collovati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps detach listener calls and onDetach calls into try-catch blocks so all
possible exceptions are handled by session ErrorHandler, and they will not
interrupt running the remaining detach handlers.
Fixes #20577