Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: WebPush Subscription Wrapper and feature flag removal #20484

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

mshabarov
Copy link
Contributor

Removes third-party nl.martijndwars.webpush.Subscription from Flow public API.
Removes the feature flag.

@mshabarov mshabarov force-pushed the add-subscription-wrapper branch from 56cd2eb to fb20e65 Compare November 15, 2024 14:07
@mshabarov mshabarov force-pushed the add-subscription-wrapper branch from fb20e65 to de7f75f Compare November 15, 2024 14:22
Copy link

Test Results

1 156 files  ± 0  1 156 suites  ±0   1h 33m 15s ⏱️ - 4m 15s
7 498 tests ± 0  7 445 ✅ ± 0  53 💤 ±0  0 ❌ ±0 
7 868 runs  +29  7 805 ✅ +29  63 💤 ±0  0 ❌ ±0 

Results for commit de7f75f. ± Comparison against base commit 35a9e49.

Copy link
Contributor

@caalador caalador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Update needed to docs.

@mshabarov mshabarov merged commit 2977de2 into main Nov 18, 2024
26 checks passed
@mshabarov mshabarov deleted the add-subscription-wrapper branch November 18, 2024 07:32
mshabarov added a commit to vaadin/docs that referenced this pull request Nov 20, 2024
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.6.0.alpha4 and is also targeting the upcoming stable 24.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants