Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fire an event when all hotswap operations have completed #20364

Merged
merged 6 commits into from
Oct 29, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Oct 29, 2024

No description provided.

Copy link

github-actions bot commented Oct 29, 2024

Test Results

1 142 files  +26  1 142 suites  +26   1h 23m 51s ⏱️ - 3m 11s
7 474 tests +26  7 424 ✅ +26  50 💤 ±0  0 ❌ ±0 
7 847 runs  +56  7 787 ✅ +56  60 💤 ±0  0 ❌ ±0 

Results for commit dea30c2. ± Comparison against base commit f1c9673.

♻️ This comment has been updated with latest results.

@Artur- Artur- requested a review from mcollovati October 29, 2024 09:36
mcollovati
mcollovati previously approved these changes Oct 29, 2024
Copy link
Collaborator

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Does it make sense to have a generic HotswapEvent (and maybe an HotswapSessionEvent) and refactor VaadinHotswapper adding methods to have it as a parameter, deprecating the existing ones? (default implementation would call the existing ones until they will be removed)

@Artur-
Copy link
Member Author

Artur- commented Oct 29, 2024

The main reason to have an event is to be able to extend or modify it without breaking existing code. A common super class does not seem super important but maybe good design if you introduce event classes for the other methods, which also could be a good idea. For a separate PR :)

@Artur- Artur- enabled auto-merge (squash) October 29, 2024 11:16
Copy link

@Artur- Artur- merged commit 0e70cb1 into main Oct 29, 2024
24 of 26 checks passed
@Artur- Artur- deleted the event-on-hotswap-complete branch October 29, 2024 11:29
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.6.0.alpha2 and is also targeting the upcoming stable 24.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants