-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Fire an event when all hotswap operations have completed #20364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Does it make sense to have a generic HotswapEvent
(and maybe an HotswapSessionEvent
) and refactor VaadinHotswapper
adding methods to have it as a parameter, deprecating the existing ones? (default implementation would call the existing ones until they will be removed)
The main reason to have an event is to be able to extend or modify it without breaking existing code. A common super class does not seem super important but maybe good design if you introduce event classes for the other methods, which also could be a good idea. For a separate PR :) |
|
… (#20373) Co-authored-by: Artur <[email protected]>
This ticket/PR has been released with Vaadin 24.6.0.alpha2 and is also targeting the upcoming stable 24.6.0 version. |
No description provided.