New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buffer leak in mkcp transport protocol #3347

Open

yiitz wants to merge 1 commit into v2fly:master from yiitz:fix-mkcp-buffer-leak

yiitz commented Mar 7, 2025 •

edited

Loading

This PR fixes two issues where buffers were not released.

defer b.Release() not woking because b is always null.

v2ray-core/transport/internet/kcp/connection.go

Lines 392 to 393 in 77d2d1b

var b *buf.Buffer

defer b.Release()
SimpleSegmentWriter.buffer never release.

v2ray-core/transport/internet/kcp/output.go

Line 24 in 77d2d1b

buffer: buf.New(),


          Fix buffer leak in mkcp transport protocol

331bc8a

Author

yiitz commented Mar 7, 2025

I'm not sure if it is the same problem here

v2ray-core/common/mux/writer.go

Line 93 in 77d2d1b

defer buf.ReleaseMulti(mb)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet