Skip to content
This repository was archived by the owner on Apr 24, 2019. It is now read-only.

Simplify templates markup #81

Closed
wants to merge 1 commit into from
Closed

Simplify templates markup #81

wants to merge 1 commit into from

Conversation

romamatusevich
Copy link
Contributor

init_page

Now index.html looks not pretty and developers before starting with init need to remove extra markup. Propose to simplify templates markup.

@drublic
Copy link
Member

drublic commented Dec 29, 2013

Thanks, we wanted to have this default markup in there to get people started fast, since you tend to add these elements anyways. What is your take on this? Do you really remove it all the time?

I am good with making it a bit prettier :)

@mischah
Copy link
Contributor

mischah commented Dec 29, 2013

+1 for the default markup. I also don’t need to have it any prettier.
Just the empty list elements are looking awful.

You could replace:

<nav role="navigation">
    <ul>
        <li></li>
        <li></li>
        <li></li>
    </ul>
</nav>

with:

<nav role="navigation">
    <ul>
        <li><a href="">Link</a></li>
        <li><a href="">Link</a></li>
        <li><a href="">Link</a></li>
    </ul>
</nav>

@romamatusevich
Copy link
Contributor Author

I think that for the fast start "Hello world! This is init." is enough to see that templates grouped correctly. Extra markup is excess and maybe imposes tips how to write HTML. As for removing markup: in every project developers need to remove footer info about project.

@mischah
Copy link
Contributor

mischah commented Dec 29, 2013

@romamatusevich I guess we won’t agree here.
But the »need« to have those boilerplate markup is just my opinion.

In all objectivity:

  • With the help of emmet there is no »pain« to add header and footer markup for me.
  • on the other hand it’s no pain for you to hit backspace a couple of times to delete some markup.

I’m out … 🙉

@anselmh
Copy link
Member

anselmh commented Dec 29, 2013

Thanks for all the feedback here. You're both right, some people want less, some more markup.

I agree stripping out all inside of <main> and <footer> would improve things. I personally think all pages have a navigation and therefore the <nav> element is important to have here. I will talk with @drublic about this and try to improve it. :)

@drublic
Copy link
Member

drublic commented Dec 30, 2013

for the fast start "Hello world! This is init." is enough

True. Let's change <main>'s content.

In general I think it is easier to hit the delete button instead of adding anything.

@anselmh anselmh closed this in 0db8f50 Dec 30, 2013
@anselmh
Copy link
Member

anselmh commented Dec 30, 2013

I modified the content and made it simpler / clearer. Thanks for the suggestions, all! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants