NetworkKeys: actually fix stale keyfile download #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pkova Thanks for the fix. Was this tested on mainnet? |
|
Yes. |
tomholford
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PR #1069 fixed the stale keyfile download issue #1068, but introduced a race condition where sometimes the point state would update prematurely, leading to the rekey never completing in the UI.
On deeper investigation I found out that the stale keyfile bug was introduced by me in #1052 when I misunderstood and changed the
checkForUpdatesfunction. This PR reverts the relevant changes in #1069 and #1052, fixing #1068 once and for all.