Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pnpm to v10.4.0 #626

Merged
merged 9 commits into from
Feb 14, 2025
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 14, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
pnpm (source) 10.3.0+sha512.ee592eda8815a8a293c206bb0917c4bb0ff274c50def7cbc17be05ec641fc2d1b02490ce660061356bd0d126a4d7eb2ec8830e6959fb8a447571c631d5a2442d -> 10.4.0 age adoption passing confidence

Release Notes

pnpm/pnpm (pnpm)

v10.4.0

Compare Source

Minor Changes
  • pnpm approve-builds --global works now for allowing dependencies of globally installed packages to run postinstall scripts.

  • The pnpm add command now supports a new flag, --allow-build, which allows building the specified dependencies. For instance, if you want to install a package called bundle that has esbuild as a dependency and want to allow esbuild to run postinstall scripts, you can run:

    pnpm --allow-build=esbuild add bundle
    

    This will run esbuild's postinstall script and also add it to the pnpm.onlyBuiltDependencies field of package.json. So, esbuild will always be allowed to run its scripts in the future.

    Related PR: #​9086.

  • The pnpm init command adds a packageManager field with the current version of pnpm CLI #​9069. To disable this behaviour, set the init-package-manager setting to false.

Patch Changes
  • pnpm approve-builds should work after two consecutive pnpm install runs #​9083.
  • Fix instruction for updating pnpm with corepack #​9101.
  • The pnpm version specified by packageManager cannot start with v.

Configuration

📅 Schedule: Branch creation - "after 4pm on thursday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@renovate renovate bot enabled auto-merge (squash) February 14, 2025 09:06
Copy link

codesandbox-ci bot commented Feb 14, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@karlhorky
Copy link
Member

karlhorky commented Feb 14, 2025

Tests are now timing out on Windows? (maybe they are hanging somehow?)

Failing test run: https://github.com/upleveled/preflight/actions/runs/13326758692/job/37221601140?pr=626

$ pnpm test
  
> @upleveled/[email protected] test D:\a\preflight\preflight
> vitest run
 RUN  v3.0.5 D:/a/preflight/preflight
 ❯ __tests__/e2e.test.ts (2 tests | 2 failed) 132422ms
   × Passes in the react-passing test project 30007ms
     → Test timed out in 30000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
   × Passes in the next-js-passing test project 45005ms
     → Test timed out in 45000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
⎯⎯⎯⎯⎯⎯⎯ Failed Tests 2 ⎯⎯⎯⎯⎯⎯⎯
 FAIL  __tests__/e2e.test.ts > Passes in the react-passing test project
Error: Test timed out in 30000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/2]⎯
 FAIL  __tests__/e2e.test.ts > Passes in the next-js-passing test project
Error: Test timed out in 45000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[2/2]⎯
  Snapshots  4 obsolete
             ↳ __tests__/e2e.test.ts
               · Passes in the next-js-passing test project 1
               · Passes in the next-js-passing test project 2
               · Passes in the react-passing test project 1
               · Passes in the react-passing test project 2
 Test Files  1 failed (1)
      Tests  2 failed (2)
   Start at  09:56:48
   Duration  133.04s (transform 77ms, setup 0ms, collect 2[15](https://github.com/upleveled/preflight/actions/runs/13326758692/job/37221601140?pr=626#step:12:16)ms, tests 132.42s, environment 0ms, prepare 130ms)
 ELIFECYCLE  Test failed. See above for more details.
Error: Process completed with exit code 1.

I increased the timeouts from 30s -> 60s and 45s -> 60s, to see if this helps:

@karlhorky
Copy link
Member

karlhorky commented Feb 14, 2025

It seems that the timeout / hanging failures is not only related to this PR - re-running previously successful tests in main (ran 10 hours ago) have now failed as well:

Maybe it was related to the update PR 8 hours ago in the preflight-test-project-react-passing:

Reverted the changes to the timeouts:

I'll merge it as is with the failures, since main is also failing currently

@renovate renovate bot merged commit 0687691 into main Feb 14, 2025
6 checks passed
@renovate renovate bot deleted the renovate/dependency-upgrades-non-major branch February 14, 2025 11:48
@karlhorky
Copy link
Member

karlhorky commented Feb 14, 2025

Weird, it passed now in the last commit here.

But then it failed again in main, with the merged commit:

pnpm test
  pnpm test
  shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
  env:
    PGHOST: localhost
    PGDATABASE: preflight_test_project_next_js_passing
    PGUSERNAME: preflight_test_project_next_js_passing
    PGPASSWORD: preflight_test_project_next_js_passing
    PNPM_HOME: C:\Users\runneradmin\setup-pnpm\node_modules\.bin

> @upleveled/[email protected] test D:\a\preflight\preflight
> vitest run


 RUN  v3.0.5 D:/a/preflight/preflight

 ❯ __tests__/e2e.test.ts (2 tests | 2 failed) 123964ms
   × Passes in the react-passing test project 30009ms
     → Test timed out in 30000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
   × Passes in the next-js-passing test project 45003ms
     → Test timed out in 45000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".

⎯⎯⎯⎯⎯⎯⎯ Failed Tests 2 ⎯⎯⎯⎯⎯⎯⎯

 FAIL  __tests__/e2e.test.ts > Passes in the react-passing test project
Error: Test timed out in 30000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/2]⎯

 FAIL  __tests__/e2e.test.ts > Passes in the next-js-passing test project
Error: Test timed out in 45000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[2/2]⎯


  Snapshots  4 obsolete
             ↳ __tests__/e2e.test.ts
               · Passes in the next-js-passing test project 1
               · Passes in the next-js-passing test project 2
               · Passes in the react-passing test project 1
               · Passes in the react-passing test project 2

 Test Files  1 failed (1)
      Tests  2 failed (2)
   Start at  11:50:02
   Duration  124.56s (transform 72ms, setup 0ms, collect 210ms, tests 123.96s, environment 0ms, prepare 129ms)

 ELIFECYCLE  Test failed. See above for more details.
Error: Process completed with exit code 1.

@karlhorky
Copy link
Member

After clearing the Actions caches, it is passing again (workflow run, no code changes):

$ pnpm test
  
> @upleveled/[email protected] test D:\a\preflight\preflight
> vitest run
 RUN  v3.0.5 D:/a/preflight/preflight
 ✓ __tests__/e2e.test.ts (2 tests) 277917ms
   ✓ Passes in the react-passing test project 21445ms
   ✓ Passes in the next-js-passing test project 30809ms
 Test Files  1 passed (1)
      Tests  2 passed (2)
   Start at  [12](https://github.com/upleveled/preflight/actions/runs/13328575188/job/37228506621#step:12:13):16:13
   Duration  278.50s (transform 64ms, setup 0ms, collect 232ms, tests 277.92s, environment 0ms, prepare 140ms)

We may need to revisit this again if this is flaky now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant