update dependencies and implement on/off toggle #12
Conversation
tkothe
force-pushed
the
on-off-switch
branch
2 times, most recently
from
f0fb612 to
6dad30b
Compare
|
Note: Here is a screenshot for me
|
|
|
||
| .btn-sendnow { | ||
| position: absolute; | ||
| left:; 15px; |
|
Hi @tkothe. Thanks for your great PR. I've added a few comments. |
|
@uiureo thanks for the review! I'll do my best to find the time to update based on your comments very soon! (might be a week or two though). I don't have Apple Music currently (canceled my subscription again recently) but it would indeed be awesome if this worked now! |
- bump version to 1.1.1 - upate npm start command to run `electron .` - remove electron-template-menu dependency - add toggle to turn automatic sending on/off (fix uiur#11) update packages (fix uiur#10) - update target electron version to 1.26 - update target electron packager version to 7.2.0 - update standard to 7.1.2 - update react version to 0.14.8 - update menubar to 4.1.2 - fix correct reference of menu item when packaging app through `npm run build`
|
@uiureo, I updated the PR based on your recommendations. Admittedly, the UI could be nicer showing the label next to the checkbox, but I was unable to get that done in short time - I'm in no way a CSS expert. |
|
Great work! Thanks @tkothe. I have a plan to update the UI, so no problem. |
|
Hi! I know this issue is a billion years old, but I was wondering if this made it into a release? This is a neat app, and I'd love to use the version that has the on/off toggle, but I'm not seeing that from the version I installed from the releases page. Is there anything I can help with? |
|
Hi @snipe! Good catch. I've forgot that for a billion years. I've created the release: https://github.com/uiureo/playing/releases/tag/v1.1.1 Let me know if there's any problem. Thanks! |
|
Thank you! Are you still interested in developing this at all? I mean, it does what it says it does, so maybe there’s nothing further to do? I’m here because you managed to not only solve my iTunes -> slack problem, but your code is pretty great, and I learned a lot about electron apps while pulling your commits from master into a local app so I could compile/use them. Are you interested in working on this anymore? I’m a backend dev myself, so React/Electron isn’t my jam specifically, but your project inspired me to install XQuartz and wine, so let me know :) |
No. I haven't used this app now, and don't have any plan to work on this. But if I had enough time, I would work on:
|
|
I completely understand. I’ve forked your repo, and if you don’t mind, I may try my hand at tweaking it a bit. I’ll still leave original credits to you of course. It’s a good excuse for me to get my feet wet with Electron, which I’ve been meaning to do forever. PS - trying to compile this (or anything else) for windows on a Mac is just as awful as you’d imagine. |
electron .update packages (fix #10)
npm run build