289 - Change :new to :edit upon failed update for PublicationsController #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janell-Huyck
force-pushed
the
bug-289-correct-failed-update-publications-controller-redirect
branch
from
a63970e to
7aa09df
Compare
haitzlm
approved these changes
Dec 5, 2023
Janell-Huyck
deleted the
bug-289-correct-failed-update-publications-controller-redirect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #289
When an update to the publication fails, it will now correctly redirect the user back to the :edit page rather than the :new page. This is in line with standard Ruby practices and would have been the expected redirection.
This bug hadn't been caught before because we didn't check what page was rendered, only that there was a "success" response. I've added this check to our publication-type update tests.